Adds multi-arch support #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds two options for multi-arch support: 1. It by default will build for the local architecture, as determined by `runtime.GOARCH`. This means you'll get a single-arch image, but it'll be for the correct architecture for your system. 2. If you specify the `--publish` flag, it will build a full multi-arch image. This requires being published to a registry through, so it's not enabled by default. Signed-off-by: Daniel Mikusa <[email protected]>
dmikusa
added
type:enhancement
anthonydahanne
approved these changes
Aug 1, 2024
| @@ -246,6 +246,8 @@ func testBuildpack(t *testing.T, context spec.G, it spec.S) { | |||
|
|
|||
| it.Before(func() { | |||
| mockExecutor = &mocks.Executor{} | |||
|
|
|||
| t.Setenv("BP_ARCH", "amd64") | |||
There was a problem hiding this comment.
oh, you want to make sure the test runs whichever the platform it runs on
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds two options for multi-arch support:
runtime.GOARCH. This means you'll get a single-arch image, but it'll be for the correct architecture for your system.--publishflag, it will build a full multi-arch image. This requires being published to a registry through, so it's not enabled by default.Use Cases
Build arm64 images locally.
Ex:
libpak-tools package bundle --buildpack-id paketo-buildpacks/amazon-correttoand you'll end up with an image relevant to your local machine.Checklist